Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging bug in dragon_install #761

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

AlyssaCote
Copy link
Contributor

@AlyssaCote AlyssaCote commented Oct 24, 2024

I added extra logging depending on the type of mismatch between the asset and the platform. I also return None if the asset is a CRAY EX asset but the platform is not a CRAY EX platform. I broke it down into these potential situations:

is cray ex platform "crayex" in asset name Results (asset, log output)
True False asset, Platform-specific package not found. Using {asset.name}
True True asset, no log output
False False asset, no log output
False True None, Platform does not support Cray EX assets

NOTE: The string crayex that we check is in the asset name will need to be changed to hsn as soon as Matt's work goes in because the asset names now have hsn instead of crayex.

@AlyssaCote AlyssaCote requested a review from ankona October 24, 2024 18:47
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.0@5bdafc5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.0     #761   +/-   ##
=======================================
  Coverage        ?   58.96%           
=======================================
  Files           ?      142           
  Lines           ?     9126           
  Branches        ?        0           
=======================================
  Hits            ?     5381           
  Misses          ?     3745           
  Partials        ?        0           

@AlyssaCote AlyssaCote merged commit 879b96e into CrayLabs:v1.0 Oct 28, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants