Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #715

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Bug fix #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f95820
oopsies
AlyssaCote Sep 20, 2024
61795b8
changelog
AlyssaCote Sep 20, 2024
2454d13
changelog
AlyssaCote Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Jump to:

Description

- Quick bug fix in _validate
- Add helper methods to MLI classes
- Update error handling for consistency
- Parameterize installation of dragon package with `smart build`
Expand Down
2 changes: 1 addition & 1 deletion smartsim/_core/mli/infrastructure/control/request_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def _check_feature_stores(self, request: InferenceRequest) -> bool:
fs_actual = {item.descriptor for item in self._feature_stores.values()}
fs_missing = fs_desired - fs_actual

if self.has_featurestore_factory:
if not self.has_featurestore_factory:
logger.error("No feature store factory configured")
return False

Expand Down
6 changes: 0 additions & 6 deletions tests/dragon/test_error_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,6 @@ def test_dispatcher_pipeline_stage_errors_handled(

mock_reply_fn = mock_pipeline_stage(monkeypatch, integrated_worker, stage)

monkeypatch.setattr(
request_dispatcher,
"_validate_request",
MagicMock(return_value=True),
)

if stage not in ["fetch_inputs"]:
monkeypatch.setattr(
integrated_worker,
Expand Down
Loading