Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure forks build latest public dragon in CI actions #706

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Sep 13, 2024

Fixes bug in build that causes dragon to fail when a PR is started from a fork.

  • Adds conditional to use dragon nightly repo from main repo only

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mli-feature@b4798da). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #706   +/-   ##
==============================================
  Coverage               ?   69.54%           
==============================================
  Files                  ?      103           
  Lines                  ?     8757           
  Branches               ?        0           
==============================================
  Hits                   ?     6090           
  Misses                 ?     2667           
  Partials               ?        0           

@ankona ankona changed the title test Ensure forks build latest public dragon in CI actions Sep 16, 2024
@ankona ankona requested review from ashao and al-rigazzi September 16, 2024 20:38
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition!

@ankona ankona merged commit b0b1db6 into CrayLabs:mli-feature Sep 18, 2024
40 of 44 checks passed
@ankona ankona deleted the conditional-dragon branch September 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants