-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TaggedFilesHierarchy with os.walk and implement configure_directory entrypoint #695
Replace TaggedFilesHierarchy with os.walk and implement configure_directory entrypoint #695
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #695 +/- ##
=====================================================
+ Coverage 40.45% 46.24% +5.78%
=====================================================
Files 110 107 -3
Lines 7326 6446 -880
=====================================================
+ Hits 2964 2981 +17
+ Misses 4362 3465 -897
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment, otherwise lgtm!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial feedback while the CI gets worked out. So far looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some general comments to get the review process started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small item but otherwise I think this is ready to merge and other items can be addressed as the user API for attaching files is updating. Thanks!
4d9ab27
into
CrayLabs:smartsim-refactor
This PR adds a configure_directory entry point, as well as tests. It also removes TaggedFilesHierarchy and replaces it with os.walk. Finally, the Generator tests have been refactored.