Remove Problematic Type Union

[MattToast]

In the shell launcher, an unintended and unused type union sunk into the ShellLauncherCommand type for the command_tuple type, allowing the attr to be of type Sequence[str] or tuple[str, tuple[str, ...]]. The former works as expected, but the latter would error at runtime when sent to the ShellLauncher when opening a subprocess.

class ShellLauncher:
    ...
    def start(self, shell_command: ShellLauncherCommand) -> LaunchedJobID:
        ...
        exe, *rest = shell_command.command_tuple
        #     ^^^^ Mypy thinks this is `list[str] | list[tuple[str]]`
        expanded_exe = helpers.expand_exe_path(exe)
        # pylint: disable-next=consider-using-with
        self._launched[id_] = sp.Popen(
            (expanded_exe, *rest),
       #    ^^^^^^^^^^^^^^^^^^^^^
       #    And inadvertently casts this to `tuple[Any]` which errors
       #    at runtime
            cwd=shell_command.path,
            env={k: v for k, v in shell_command.env.items() if v is not None},
            stdout=shell_command.stdout,
            stderr=shell_command.stderr,
        )
        ...

Because this type was not being used, it can simply be removed from the union.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.95%. Comparing base (cce16e6) to head (1b57749).
Report is 19 commits behind head on smartsim-refactor.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           smartsim-refactor     #694      +/-   ##
=====================================================
+ Coverage              40.45%   43.95%   +3.49%     
=====================================================
  Files                    110      110              
  Lines                   7326     7134     -192     
=====================================================
+ Hits                    2964     3136     +172     
+ Misses                  4362     3998     -364     

Files with missing lines	Coverage Δ
smartsim/_core/shell/shellLauncher.py	95.06% <100.00%> (+34.19%)	⬆️

... and 6 files with indirect coverage changes

[amandarichardsonn]

LGTM!

[amandarichardsonn]

LGTM! Thanks for catching that.