-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removals of EntityList, EntitySequence, JobManager, and Controller #693
Removals of EntityList, EntitySequence, JobManager, and Controller #693
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #693 +/- ##
=====================================================
+ Coverage 40.45% 46.32% +5.86%
=====================================================
Files 110 106 -4
Lines 7326 6450 -876
=====================================================
+ Hits 2964 2988 +24
+ Misses 4362 3462 -900
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you go into pyproject.toml and delete the files that you deleted from the list starting at line 150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3bfdff9
into
CrayLabs:smartsim-refactor
No description provided.