Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Can Stop Launched Jobs #677

Merged
merged 12 commits into from
Aug 30, 2024

Testing launcher acts like a 'real' launcher

24a170f
Select commit
Loading
Failed to load commit list.
Merged

Experiment Can Stop Launched Jobs #677

Testing launcher acts like a 'real' launcher
24a170f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 0s

43.59% (target 0.00%)

View this Pull Request on Codecov

43.59% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.59%. Comparing base (cce16e6) to head (24a170f).
Report is 8 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/shell/shellLauncher.py 92.00% 2 Missing ⚠️
smartsim/_core/launcher/dragon/dragonLauncher.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #677      +/-   ##
=====================================================
+ Coverage              40.45%   43.59%   +3.13%     
=====================================================
  Files                    110      110              
  Lines                   7326     7076     -250     
=====================================================
+ Hits                    2964     3085     +121     
+ Misses                  4362     3991     -371     
Files with missing lines Coverage Δ
smartsim/_core/utils/launcher.py 95.65% <100.00%> (ø)
smartsim/experiment.py 86.33% <100.00%> (+4.77%) ⬆️
smartsim/_core/launcher/dragon/dragonLauncher.py 27.52% <50.00%> (+0.82%) ⬆️
smartsim/_core/shell/shellLauncher.py 95.06% <92.00%> (+34.19%) ⬆️

... and 4 files with indirect coverage changes