Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init reordering bug #675

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 26, 2024

Fix 3 bugs:

  1. reordering the init sequence in the dragon backend resulted in an un-set collection being used
  2. fix tests that should have been updated to compare set contents instead of individual items
  3. remove newly added validation on empty host lists that broke existing tests

@ankona ankona force-pushed the node-check-reorder-fix branch from 2796bc6 to 53800a0 Compare August 26, 2024 19:26
@ankona ankona force-pushed the node-check-reorder-fix branch from 53800a0 to b2739d3 Compare August 26, 2024 19:27
@ankona ankona marked this pull request as ready for review August 26, 2024 19:37
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@ef034d5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #675   +/-   ##
==============================================
  Coverage               ?   79.26%           
==============================================
  Files                  ?       98           
  Lines                  ?     7910           
  Branches               ?        0           
==============================================
  Hits                   ?     6270           
  Misses                 ?     1640           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher/dragon/pqueue.py 90.42% <ø> (ø)
smartsim/_core/launcher/dragon/dragonBackend.py 1.96% <0.00%> (ø)
---- 🚨 Try these New Features:

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@ankona ankona merged commit 6d5518b into CrayLabs:mli-feature Aug 26, 2024
40 of 44 checks passed
@ankona ankona deleted the node-check-reorder-fix branch September 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants