-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event broadcasting capability #672
Conversation
XxxCommChannel
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #672 +/- ##
==============================================
Coverage ? 69.65%
==============================================
Files ? 103
Lines ? 8732
Branches ? 0
==============================================
Hits ? 6082
Misses ? 2650
Partials ? 0
|
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments before seeing the integration additions.
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/backbonefeaturestore.py
Outdated
Show resolved
Hide resolved
0a59ba8
to
3f54739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing that I'd like to be addressed, namely the different timeouts. The rest looks very promising!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tiny comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more comments :)
smartsim/_core/mli/infrastructure/storage/backbone_feature_store.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/dragon_feature_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Event broadcasting will enable the system to notify other MLI resources of changes. This PR contains the base capabilities required for publishing & consuming channel messages as events.