Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event broadcasting capability #672

Merged
merged 17 commits into from
Sep 10, 2024
Merged

Add event broadcasting capability #672

merged 17 commits into from
Sep 10, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 21, 2024

Event broadcasting will enable the system to notify other MLI resources of changes. This PR contains the base capabilities required for publishing & consuming channel messages as events.

@ankona ankona changed the title Add event broadcasting via XxxCommChannel Add event broadcasting capability Aug 21, 2024
@ankona ankona requested a review from AlyssaCote August 21, 2024 20:20
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 232 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@f6d55d8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...i/infrastructure/storage/backbone_feature_store.py 0.00% 172 Missing ⚠️
.../_core/mli/infrastructure/storage/feature_store.py 0.00% 42 Missing ⚠️
...mli/infrastructure/storage/dragon_feature_store.py 0.00% 9 Missing ⚠️
...e/mli/infrastructure/control/request_dispatcher.py 0.00% 5 Missing ⚠️
smartsim/_core/utils/timings.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #672   +/-   ##
==============================================
  Coverage               ?   69.65%           
==============================================
  Files                  ?      103           
  Lines                  ?     8732           
  Branches               ?        0           
==============================================
  Hits                   ?     6082           
  Misses                 ?     2650           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/utils/timings.py 0.00% <0.00%> (ø)
...e/mli/infrastructure/control/request_dispatcher.py 0.00% <0.00%> (ø)
...mli/infrastructure/storage/dragon_feature_store.py 0.00% <0.00%> (ø)
.../_core/mli/infrastructure/storage/feature_store.py 0.00% <0.00%> (ø)
...i/infrastructure/storage/backbone_feature_store.py 0.00% <0.00%> (ø)

@ankona ankona marked this pull request as ready for review August 21, 2024 20:43
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments before seeing the integration additions.

@ankona ankona force-pushed the 747 branch 2 times, most recently from 0a59ba8 to 3f54739 Compare August 28, 2024 13:23
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that I'd like to be addressed, namely the different timeouts. The rest looks very promising!

Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more tiny comments :)

@ankona ankona requested a review from al-rigazzi September 3, 2024 18:02
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more comments :)

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankona ankona merged commit a3795e7 into CrayLabs:mli-feature Sep 10, 2024
41 of 44 checks passed
@ankona ankona deleted the 747 branch September 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants