Unit tests for ShellLauncher & additional shell launch context #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REBASEME: moar mpi REBASEME: fmt mpi
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
MattToast
reviewed
Aug 27, 2024
tests/test_shell_launcher.py
Outdated
Comment on lines
43
to
47
| # TODO tests bad vars in Popen call at beginning | ||
| # tests -> helper.exe : pass in None, empty str, path with a space at beginning, a non valid command | ||
| # -> write a test for the invalid num of items - test_shell_launcher_fails_on_any_invalid_len_input | ||
| # -> have border tests for 0,1,4,6 cmd vals -> work correctly without them -> raise ValueError | ||
| # do all of the failures as well as the sucess criteria |
There was a problem hiding this comment.
Is this TODO still needed? I think I saw some of this being tested, but not all. Is this something we want to address in this PR or a follow on? If a follow on, is there a ticket somewhere for this work??
There was a problem hiding this comment.
- invalid num of items is not required given that it was written down during the era of unpacking a tuple and expecting the length to be #.
- I do not believe border tests for cmd vals is necessary given the new NamedTuple
- can probably add a check for popen cwd
MattToast
requested changes
Aug 27, 2024
MattToast
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Some minor nits on the shell launcher tests, but nothing worth holding approval up over!
LGTM, thanks for all the hard work on this! Now that we are successfully generating logs to the right spot for all of our primitive jobs we are shaping up to be in really good shape for the V1 API!!
amandarichardsonn
merged commit f9a86d9
into
CrayLabs:smartsim-refactor
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.