Merge develop into smartsim-refactor #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abs#653) This PR mitigates two issues encountered during installation on build agents ## mypy/typing_extensions Installation of mypy or dragon in separate build actions caused some dependencies (typing_extensions, numpy) to be upgraded. Those upgrades result in runtime failures. The build actions were tweaked to allow pip to consider all optional dependencies during resolution. ## dragon/numpy Additionally, the numpy version was capped on dragon installations. [ committed by @ankona] [ approved by @ashao @MattToast ]
The builder module was included in `setup.py` to allow us to ship the main Redis binaries (not RedisAI) with installs from PyPI. The changes in this PR remove our ability to do this and requires users to build Redis as part of the `smart build`. This change in behaviour was deemed reasonable to allow for easier maintenance and extension of the Builder class as well as simplify the deployment of wheels. [ committed by @ashao ] [ reviewed by @MattToast ]
The version of codecov has been updated to v4.5.0 for the github actions. [ committed by @mellis13 ] [ reviewed by @amandarichardsonn ]
MattToast
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Looks like this is still failing to build on the CI. It looks like you are using undefined symbols install, build_py, and Distribution in the setup.py (they came from removed imports).
It looks like these were removed from develop, do you still need them here??
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #668 +/- ##
====================================================
Coverage ? 40.32%
====================================================
Files ? 108
Lines ? 7301
Branches ? 0
====================================================
Hits ? 2944
Misses ? 4357
Partials ? 0 |
MattToast
approved these changes
Aug 15, 2024
juliaputko
merged commit 7ddb12f
into
CrayLabs:smartsim-refactor
33 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.