-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmartSim environment variables updated using new naming convention #666
SmartSim environment variables updated using new naming convention #666
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #666 +/- ##
==============================================
Coverage ? 71.34%
==============================================
Files ? 102
Lines ? 8525
Branches ? 0
==============================================
Hits ? 6082
Misses ? 2443
Partials ? 0
|
Do we think that this PR should be labeled as an API break? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some renaming suggestions, but I'm also ok if we don't do it in this PR.
This PR updates environment variable names with the new convention.
SMARTSIM_DRAGON_SERVER_PATH_EXP
->_SMARTSIM_DRAGON_SERVER_PATH_EXP
RAI_PATH
->SMARTSIM_RAI_LIB
REDIS_PATH
->SMARTSIM_REDIS_SERVER_EXE
REDIS_CLI_PATH
->SMARTSIM_REDIS_CLI_EXE
REDIS_CONF
->SMARTSIM_REDIS_CONF