Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartSim environment variables updated using new naming convention #666

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

AlyssaCote
Copy link
Contributor

@AlyssaCote AlyssaCote commented Aug 12, 2024

This PR updates environment variable names with the new convention.

SMARTSIM_DRAGON_SERVER_PATH_EXP -> _SMARTSIM_DRAGON_SERVER_PATH_EXP
RAI_PATH -> SMARTSIM_RAI_LIB
REDIS_PATH -> SMARTSIM_REDIS_SERVER_EXE
REDIS_CLI_PATH -> SMARTSIM_REDIS_CLI_EXE
REDIS_CONF -> SMARTSIM_REDIS_CONF

@AlyssaCote AlyssaCote changed the title SmartSIm environment variables updated using new naming convention SmartSim environment variables updated using new naming convention Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@128598b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/experiment.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #666   +/-   ##
==============================================
  Coverage               ?   71.34%           
==============================================
  Files                  ?      102           
  Lines                  ?     8525           
  Branches               ?        0           
==============================================
  Hits                   ?     6082           
  Misses                 ?     2443           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/config/config.py 97.14% <100.00%> (ø)
smartsim/_core/utils/helpers.py 91.54% <100.00%> (ø)
smartsim/database/orchestrator.py 81.76% <ø> (ø)
smartsim/experiment.py 85.77% <0.00%> (ø)

@AlyssaCote AlyssaCote requested a review from ashao August 14, 2024 16:03
@mellis13
Copy link
Contributor

Do we think that this PR should be labeled as an API break?

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some renaming suggestions, but I'm also ok if we don't do it in this PR.

@AlyssaCote AlyssaCote added the API break Issues that include incompatible API changes label Aug 20, 2024
@AlyssaCote AlyssaCote merged commit 8aa990c into CrayLabs:mli-feature Aug 29, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break Issues that include incompatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants