-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Slurm specific methods from LaunchArguments #662
Removed Slurm specific methods from LaunchArguments #662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of sanity checks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of slightly tighter type hints if you want, and some small style failures in the CI, but otherwise looks about ready on my end!
LGTM!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #662 +/- ##
=====================================================
+ Coverage 40.45% 40.51% +0.05%
=====================================================
Files 110 111 +1
Lines 7326 7324 -2
=====================================================
+ Hits 2964 2967 +3
+ Misses 4362 4357 -5
|
a0cc447
into
CrayLabs:smartsim-refactor
No description provided.