-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specification of target hostname for a dragon task #660
Conversation
5163932
to
d351bde
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #660 +/- ##
==============================================
Coverage ? 79.26%
==============================================
Files ? 98
Lines ? 7914
Branches ? 0
==============================================
Hits ? 6273
Misses ? 1641
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial comments while you are making updates. Love the robust commenting and documentation! It really helped make the review process easier and makes the code more maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You resolved all of my previous comments with your new updates! This looks great me, just a few clean up comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the updates. Just a couple of comments but overall love the improvements!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks awesome! The Backend is slowly but steadily getting much more readable, thanks!
move prioritizer overwriting into fixture cleanup backend mocks
Description
This PR adds two features:
Specifying Hostnames
The existing
DragonRunRequest
supported the ability to specify a hostname when creating a policy used to run a task. However, the hostnames were not exposed to clients.This ticket allows clients to pass a list of hosts that will be used in place of the default "first available host" behavior.
Task Colocation
The prior system for finding nodes to execute a task worked worked only with unassigned nodes. Any node assigned a task could not be assigned another task.
This ticket adds a more capable prioritizer class that enables clients using hostnames to colocate tasks. It also retains the capability to return open nodes when no hostname is specified.