Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move smartsim.settings.dispatch module under smartsim._core #659

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

@juliaputko juliaputko requested a review from MattToast August 7, 2024 22:44
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for @MattToast to give a quick approval as well.

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! just need to run isort and fix up those last merge conflicts (caused by me from my last PR, sorry! 😬).

None of this seems like a reason to hold up approval though! LGTM!!

@juliaputko juliaputko merged commit ddde9c5 into CrayLabs:smartsim-refactor Aug 14, 2024
19 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants