-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis removal #656
Redis removal #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! I pointed out a few places where you could be even more aggressive in you redis removal, but the build thing right now is getting this PR to build and get past the CI. Once we get that done, this should be about ready to go!
Thanks for helping clean up all of the debt!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of ocmments but this is a really good start removing redisAI content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor nits, and I think I saw a couple of static/style/typing things the CI might complain about, but once the CI is passing this LGTM!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #656 +/- ##
=====================================================
+ Coverage 40.32% 41.48% +1.16%
=====================================================
Files 108 106 -2
Lines 7301 6985 -316
=====================================================
- Hits 2944 2898 -46
+ Misses 4357 4087 -270
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good riddance Redis!! LGTM, thanks for taking care of this!
f6928e5
into
CrayLabs:smartsim-refactor
Removed all references to Redis and RedisAI except for in tests, in docker build, and in docs