Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis removal #656

Merged
merged 19 commits into from
Aug 22, 2024
Merged

Conversation

juliaputko
Copy link
Contributor

Removed all references to Redis and RedisAI except for in tests, in docker build, and in docs

@juliaputko juliaputko requested a review from MattToast August 6, 2024 00:03
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! I pointed out a few places where you could be even more aggressive in you redis removal, but the build thing right now is getting this PR to build and get past the CI. Once we get that done, this should be about ready to go!

Thanks for helping clean up all of the debt!!

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of ocmments but this is a really good start removing redisAI content

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor nits, and I think I saw a couple of static/style/typing things the CI might complain about, but once the CI is passing this LGTM!!

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (bf348a0) to head (97483cf).
Report is 19 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/control/controller.py 62.50% 6 Missing ⚠️
smartsim/ml/data.py 33.33% 6 Missing ⚠️
smartsim/_core/utils/telemetry/collector.py 40.00% 3 Missing ⚠️
smartsim/_core/launcher/step/step.py 50.00% 1 Missing ⚠️
smartsim/database/orchestrator.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #656      +/-   ##
=====================================================
+ Coverage              40.32%   41.48%   +1.16%     
=====================================================
  Files                    108      106       -2     
  Lines                   7301     6985     -316     
=====================================================
- Hits                    2944     2898      -46     
+ Misses                  4357     4087     -270     
Files with missing lines Coverage Δ
smartsim/_core/config/config.py 79.72% <100.00%> (+15.92%) ⬆️
smartsim/_core/utils/__init__.py 100.00% <ø> (ø)
smartsim/_core/utils/helpers.py 40.68% <ø> (+0.50%) ⬆️
smartsim/ml/tf/utils.py 26.92% <ø> (ø)
smartsim/ml/torch/data.py 27.86% <100.00%> (+5.06%) ⬆️
smartsim/_core/launcher/step/step.py 42.16% <50.00%> (-0.52%) ⬇️
smartsim/database/orchestrator.py 20.11% <83.33%> (-0.38%) ⬇️
smartsim/_core/utils/telemetry/collector.py 33.49% <40.00%> (ø)
smartsim/_core/control/controller.py 16.35% <62.50%> (+1.17%) ⬆️
smartsim/ml/data.py 32.27% <33.33%> (+7.61%) ⬆️
---- 🚨 Try these New Features:

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance Redis!! LGTM, thanks for taking care of this!

@juliaputko juliaputko merged commit f6928e5 into CrayLabs:smartsim-refactor Aug 22, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants