Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test overwriting a test configuration file #648

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix test overwriting a test configuration file #648

merged 1 commit into from
Jul 31, 2024

Conversation

MattToast
Copy link
Member

@MattToast MattToast commented Jul 25, 2024 •
edited
Loading

Running pytest tests/test_file_operations.py was overwriting a test configuration file. This PR fixes the offending test and adds a missing assert statement.

@MattToast MattToast added area: test Issues related to the test suite bug: minor A minor bug ignore-for-release labels Jul 25, 2024
@MattToast MattToast requested a review from juliaputko July 25, 2024 22:20
@MattToast MattToast self-assigned this Jul 25, 2024
@MattToast MattToast force-pushed the dont-overwrite-test-conf-files branch from 8744053 to a03f609 Compare July 27, 2024 00:29
@MattToast MattToast mentioned this pull request Jul 31, 2024
Merged
juliaputko
juliaputko approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@juliaputko juliaputko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks for these changes

@MattToast MattToast merged commit a2c1251 into CrayLabs:smartsim-refactor Jul 31, 2024
32 of 33 checks passed
@MattToast MattToast deleted the dont-overwrite-test-conf-files branch August 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaputko juliaputko juliaputko approved these changes

Assignees

@MattToast MattToast

Labels
area: test Issues related to the test suite bug: minor A minor bug ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattToast @juliaputko