Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in worker manager #629

Merged
merged 61 commits into from
Jul 18, 2024

Conversation

AlyssaCote
Copy link
Contributor

@AlyssaCote AlyssaCote commented Jul 2, 2024

This PR aims to allow the WorkerManager to continue if a worker throws an error. The WorkerManager needs to return a Response without blowing up in the process.

@AlyssaCote AlyssaCote marked this pull request as draft July 2, 2024 22:09
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@eace71e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/mli/infrastructure/worker/worker.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #629   +/-   ##
==============================================
  Coverage               ?   65.62%           
==============================================
  Files                  ?       97           
  Lines                  ?     6699           
  Branches               ?        0           
==============================================
  Hits                   ?     4396           
  Misses                 ?     2303           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/mli/message_handler.py 75.82% <ø> (ø)
smartsim/_core/mli/infrastructure/worker/worker.py 79.01% <0.00%> (ø)

@AlyssaCote AlyssaCote requested a review from ankona July 8, 2024 16:12
@AlyssaCote AlyssaCote marked this pull request as ready for review July 8, 2024 16:55
@AlyssaCote AlyssaCote changed the title [WIP] Improve error handling in worker manager Improve error handling in worker manager Jul 15, 2024
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions/comments

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlyssaCote AlyssaCote merged commit 272a1d7 into CrayLabs:mli-feature Jul 18, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants