-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling in worker manager #629
Improve error handling in worker manager #629
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #629 +/- ##
==============================================
Coverage ? 65.62%
==============================================
Files ? 97
Lines ? 6699
Branches ? 0
==============================================
Hits ? 4396
Misses ? 2303
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions/comments
This reverts commit 0af26a1. revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR aims to allow the
WorkerManager
to continue if aworker
throws an error. TheWorkerManager
needs to return aResponse
without blowing up in the process.