Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model metadata to request schema #624

Merged
merged 12 commits into from
Jul 3, 2024

Conversation

AlyssaCote
Copy link
Contributor

This PR adds a Model schema in the Request schema with metadata about the model included so that it's not just a data blob. I also tweaked some of the attribute names. For example, what was request.input.inputKeys is now request.input.keys.

@AlyssaCote AlyssaCote requested review from ankona and al-rigazzi June 27, 2024 18:53
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@ee2c110). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../_core/mli/infrastructure/control/workermanager.py 0.00% 10 Missing ⚠️
smartsim/_core/mli/message_handler.py 78.26% 5 Missing ⚠️
smartsim/_core/mli/infrastructure/worker/worker.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #624   +/-   ##
==============================================
  Coverage               ?   66.82%           
==============================================
  Files                  ?       97           
  Lines                  ?     6734           
  Branches               ?        0           
==============================================
  Hits                   ?     4500           
  Misses                 ?     2234           
  Partials               ?        0           
Files with missing lines Coverage Δ
...core/mli/mli_schemas/data/data_references_capnp.py 100.00% <ø> (ø)
...martsim/_core/mli/mli_schemas/model/model_capnp.py 100.00% <100.00%> (ø)
...est/request_attributes/request_attributes_capnp.py 100.00% <ø> (ø)
...sim/_core/mli/mli_schemas/request/request_capnp.py 100.00% <ø> (ø)
...e/response_attributes/response_attributes_capnp.py 100.00% <ø> (ø)
...m/_core/mli/mli_schemas/response/response_capnp.py 100.00% <ø> (ø)
...rtsim/_core/mli/mli_schemas/tensor/tensor_capnp.py 100.00% <ø> (ø)
smartsim/_core/mli/infrastructure/worker/worker.py 78.48% <50.00%> (ø)
smartsim/_core/mli/message_handler.py 75.82% <78.26%> (ø)
.../_core/mli/infrastructure/control/workermanager.py 18.10% <0.00%> (ø)

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a couple minor license issues and a potential breaking bug to fix. Otherwise, looks good.

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlyssaCote AlyssaCote merged commit 8a2f173 into CrayLabs:mli-feature Jul 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants