Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable environment variable based configuration for ML Worker Manager #621

Merged
merged 52 commits into from
Jul 10, 2024
Merged

Enable environment variable based configuration for ML Worker Manager #621

merged 52 commits into from
Jul 10, 2024

Conversation

AlyssaCote
Copy link
Contributor

This PR adds a EnvironmentConfigLoader, which loads and deserializes an SSFeatureStore and an SSQueue from environment variables for the ML Worker Manager.

@AlyssaCote AlyssaCote requested review from ankona and al-rigazzi June 24, 2024 20:57
@AlyssaCote AlyssaCote marked this pull request as draft June 25, 2024 22:48
@AlyssaCote AlyssaCote marked this pull request as ready for review June 26, 2024 16:32
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@8a2f173). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% 20 Missing ⚠️
...e/mli/infrastructure/storage/dragonfeaturestore.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #621   +/-   ##
==============================================
  Coverage               ?   67.48%           
==============================================
  Files                  ?       96           
  Lines                  ?     6627           
  Branches               ?        0           
==============================================
  Hits                   ?     4472           
  Misses                 ?     2155           
  Partials               ?        0
Files with missing lines Coverage Δ
...e/mli/infrastructure/storage/dragonfeaturestore.py 0.00% <0.00%> (ø)
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% <0.00%> (ø)

@al-rigazzi al-rigazzi mentioned this pull request Jul 5, 2024
Merged
ankona
ankona reviewed Jul 9, 2024
View reviewed changes
ankona
ankona approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlyssaCote AlyssaCote merged commit 52abd32 into CrayLabs:mli-feature Jul 10, 2024
44 checks passed
@al-rigazzi al-rigazzi mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankona ankona ankona approved these changes

@al-rigazzi al-rigazzi Awaiting requested review from al-rigazzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlyssaCote @ankona