Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job and MPMD Job Implementation #603

Merged
merged 18 commits into from
Jun 7, 2024
Merged

Job and MPMD Job Implementation #603

merged 18 commits into from
Jun 7, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

amandarichardsonn
amandarichardsonn suggested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome code!! Heres some thoughts/feedback

amandarichardsonn
amandarichardsonn approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Please upload report for BASE (smartsim-refactor@883824b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/launchable/mpmdjob.py 0.00% 44 Missing ⚠️
smartsim/launchable/job.py 0.00% 23 Missing ⚠️
smartsim/launchable/mpmdpair.py 0.00% 6 Missing ⚠️
smartsim/launchable/__init__.py 0.00% 5 Missing ⚠️
smartsim/launchable/launchable.py 0.00% 4 Missing ⚠️
smartsim/launchable/basejob.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             smartsim-refactor     #603   +/-   ##
====================================================
  Coverage                     ?   30.27%           
====================================================
  Files                        ?       84           
  Lines                        ?     6090           
  Branches                     ?        0           
====================================================
  Hits                         ?     1844           
  Misses                       ?     4246           
  Partials                     ?        0
Files with missing lines Coverage Δ
smartsim/launchable/basejob.py 0.00% <0.00%> (ø)
smartsim/launchable/launchable.py 0.00% <0.00%> (ø)
smartsim/launchable/__init__.py 0.00% <0.00%> (ø)
smartsim/launchable/mpmdpair.py 0.00% <0.00%> (ø)
smartsim/launchable/job.py 0.00% <0.00%> (ø)
smartsim/launchable/mpmdjob.py 0.00% <0.00%> (ø)

@juliaputko juliaputko merged commit b64af80 into CrayLabs:smartsim-refactor Jun 7, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandarichardsonn amandarichardsonn amandarichardsonn approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliaputko @amandarichardsonn