Dragon server enhancement #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashao
approved these changes
May 14, 2024
| @@ -130,7 +130,10 @@ def redir_worker(io_conn: dragon_connection.Connection, file_path: str) -> None: | |||
| except Exception as e: | |||
| print(e) | |||
| finally: | |||
| io_conn.close() | |||
| try: | |||
| io_conn.close() | |||
There was a problem hiding this comment.
Can you explain why this is a universal catch and print? Is it that io_conn can fail out in a number of ways? Would re-reraising the error result in too much crashing down?
There was a problem hiding this comment.
Yeah, I'm a bit scared of raising an exception and taking down all the dragon infra. I'll put up a ticket to investigate better ways of handling this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #582 +/- ##
============================================
- Coverage 79.12% 60.63% -18.50%
============================================
Files 78 78
Lines 5988 6000 +12
============================================
- Hits 4738 3638 -1100
- Misses 1250 2362 +1112
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dragon server could fail, dumping a core file, if it was shut down before all spawned Process Groups completed. This PR fixes such behavior: the immediate flag on the
DragonShutdownRequestnow requests every non-terminated job to be stopped.