Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ubuntu to 22.04 #558

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

AlyssaCote
Copy link
Contributor

After dropping python 3.8, there's been some issues with ubuntu versions for the smartsim dev docs. Upgrading ubuntu to 22.04 is necessary now that we've dropped support for python 3.8 and should solve the problem.

@AlyssaCote AlyssaCote marked this pull request as draft April 18, 2024 23:46
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.96%. Comparing base (f5beb41) to head (aef710a).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #558      +/-   ##
===========================================
+ Coverage    71.12%   71.96%   +0.84%     
===========================================
  Files           65       65              
  Lines         4544     4534      -10     
===========================================
+ Hits          3232     3263      +31     
+ Misses        1312     1271      -41     

see 12 files with indirect coverage changes

@AlyssaCote AlyssaCote marked this pull request as ready for review April 19, 2024 00:12
@AlyssaCote AlyssaCote requested a review from ashao April 19, 2024 00:13
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@AlyssaCote AlyssaCote merged commit 04ea493 into CrayLabs:develop Apr 19, 2024
36 checks passed
@amandarichardsonn amandarichardsonn added bug: minor A minor bug area: CI/CD Issues related to continuous integration and deployment and removed bug: minor A minor bug labels Apr 25, 2024
ankona pushed a commit to ankona/SmartSim that referenced this pull request May 6, 2024
Bump ubuntu to version 22.04

[ committed by @AlyssaCote ]
[ reviewed by @ashao ]
ankona pushed a commit to ankona/SmartSim that referenced this pull request May 7, 2024
Bump ubuntu to version 22.04

[ committed by @AlyssaCote ]
[ reviewed by @ashao ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment non-user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants