Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readthedocs import extension error #537

Merged
merged 24 commits into from
Apr 4, 2024

Conversation

amandarichardsonn
Copy link
Contributor

@amandarichardsonn amandarichardsonn commented Apr 2, 2024

Readthedocs fails and is blocking existing PRs. Failure is: Extension error: Could not import extension sphinx_tabs.tabs (exception: cannot import name 'TypeAliasType' from 'typing_extensions'). The issue came from pydantic==2.6.4 and typing_extensions==4.5.0. Sphinx uses Open AI which requires "pydantic>=1.9.0, <3", "typing-extensions>=4.7, <5". The versions have been changed in requirements-doc.txt.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (6f800b1) to head (be504e2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #537   +/-   ##
========================================
  Coverage    90.70%   90.70%           
========================================
  Files           65       65           
  Lines         4498     4498           
========================================
  Hits          4080     4080           
  Misses         418      418           

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this and fixing it so elegantly!

@amandarichardsonn amandarichardsonn merged commit d462fd2 into CrayLabs:develop Apr 4, 2024
44 checks passed
@amandarichardsonn amandarichardsonn deleted the readthedocs branch April 4, 2024 16:38
@amandarichardsonn amandarichardsonn added the area: docs Issues related to documentation label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation bug: minor A minor bug non-user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants