Change default path for entities #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandarichardsonn
added
area: python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #533 +/- ##
==========================================
Coverage ? 71.03%
==========================================
Files ? 65
Lines ? 4544
Branches ? 0
==========================================
Hits ? 3228
Misses ? 1316
Partials ? 0
|
ashao
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Looking pretty good. See the above comments for specific places but overall here are the items to address:
- Try to avoid mixing using os.path and pathlib where possible
- See if you can figure out a way to monkeypatch exp.start so that you can avoid actually having to run the database and other entities
One task to address that's outside of the inline comments:
- Go through the rest of the tests and make sure that we're not unnecessarily setting their paths anymore
ashao
requested changes
Apr 16, 2024
mellis13
suggested changes
Apr 16, 2024
mellis13
approved these changes
Apr 17, 2024
ashao
approved these changes
Apr 17, 2024
amandarichardsonn
added
type: usability
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 6, 2024
This PR makes changes to the default path for SS entities. New default path is `exp_path/entity_name/`. A path argument has also been added to create_ensemble and create_model. [ reviewed by @ashao @mellis13 ] [ committed by @amandarichardsonn ]
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 7, 2024
This PR makes changes to the default path for SS entities. New default path is `exp_path/entity_name/`. A path argument has also been added to create_ensemble and create_model. [ reviewed by @ashao @mellis13 ] [ committed by @amandarichardsonn ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the default path for SS entities. New default path is
exp_path/entity_name/.