-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment Preview #447
Experiment Preview #447
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## preview #447 +/- ##
===========================================
+ Coverage 90.01% 90.32% +0.31%
===========================================
Files 60 61 +1
Lines 3826 3866 +40
===========================================
+ Hits 3444 3492 +48
+ Misses 382 374 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good starting point, I agree with @ankona's suggestion to use static methods. @MattToast may want to chime in as well.
smartsim/log.py
Outdated
""" | ||
logger.propagate = False | ||
fmt = None | ||
formatter = logging.Formatter(fmt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want a None here? would "%(message)s"
do the job?
I don't even know what happens if you have a null formatter!
No description provided.