Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Preview #447

Merged
merged 34 commits into from
Feb 13, 2024
Merged

Experiment Preview #447

merged 34 commits into from
Feb 13, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (bbce88a) 90.01% compared to head (ca84b72) 90.32%.

❗ Current head ca84b72 differs from pull request most recent head 7d48a1e. Consider uploading reports for the commit 7d48a1e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           preview     #447      +/-   ##
===========================================
+ Coverage    90.01%   90.32%   +0.31%     
===========================================
  Files           60       61       +1     
  Lines         3826     3866      +40     
===========================================
+ Hits          3444     3492      +48     
+ Misses         382      374       -8     
Files Coverage Δ
smartsim/_core/__init__.py 100.00% <100.00%> (ø)
smartsim/error/errors.py 100.00% <100.00%> (ø)
smartsim/_core/control/manifest.py 95.91% <66.66%> (-0.61%) ⬇️
smartsim/experiment.py 82.71% <40.00%> (-2.91%) ⬇️
smartsim/_core/control/previewrenderer.py 50.00% <50.00%> (ø)

... and 8 files with indirect coverage changes

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good starting point, I agree with @ankona's suggestion to use static methods. @MattToast may want to chime in as well.

smartsim/log.py Outdated
"""
logger.propagate = False
fmt = None
formatter = logging.Formatter(fmt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want a None here? would "%(message)s" do the job?

I don't even know what happens if you have a null formatter!

@juliaputko juliaputko marked this pull request as ready for review February 13, 2024 00:04
@juliaputko juliaputko merged commit d130633 into CrayLabs:preview Feb 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants