Fix colocated db preparation bug when using JsrunSettings

[ankona]

A model fails to properly configure colocated db settings when the run settings are of type JsrunSettings. This bug was introduced when protected members were made public (due to linter noting public use) but the change was partially rolled back.

The model method _set_colocated_db_settings attempts the following:

        if hasattr(self.run_settings, "prep_colocated_db"):
            self.run_settings.prep_colocated_db(common_options["cpus"])

There are no run settings classes with an attribute of that name. JsrunSettings does have _prep_colocated_db (note protected/underscore).

 def _prep_colocated_db(self, db_cpus: int) -> None:
        cpus_per_flag_set = False
        for cpu_per_rs_flag in ["cpu_per_rs", "c"]:
            if run_arg_value := self.run_args.get(cpu_per_rs_flag, 0):
                cpus_per_flag_set = True
                ...

This change fixes the incorrect call to a non-existent method by invoking self.run_settings._prep_colocated_db(...) instead.

[codecov]

Codecov Report

Merging #339 (9dc1f28) into develop (6125f3c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #339      +/-   ##
===========================================
+ Coverage    87.17%   87.19%   +0.02%     
===========================================
  Files           59       59              
  Lines         3531     3531              
===========================================
+ Hits          3078     3079       +1     
+ Misses         453      452       -1     

Files Changed	Coverage Δ
smartsim/entity/model.py	95.77% <100.00%> (+0.70%)	⬆️

[MattToast]

Good catch! LGTM, pending one change to the changelog

[MattToast]

One small question, but otherwise my approval stands!