Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in logging msg format string #332

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 1, 2023

Fix another buggy format string in logging introduced during lint mitigation.

Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #332 (b655c3a) into develop (b3484b6) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #332      +/-   ##
===========================================
+ Coverage    87.20%   87.32%   +0.11%     
===========================================
  Files           59       59              
  Lines         3526     3526              
===========================================
+ Hits          3075     3079       +4     
+ Misses         451      447       -4     
Files Changed Coverage Δ
smartsim/_core/control/controller.py 84.15% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ankona ankona merged commit c8ea7ea into CrayLabs:develop Aug 1, 2023
@MattToast MattToast added the bug: minor A minor bug label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor A minor bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants