Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis conf file #293

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Update redis conf file #293

merged 5 commits into from
Jun 5, 2023

Conversation

mellis13
Copy link
Contributor

@mellis13 mellis13 commented Jun 1, 2023

This PR changes the redis conf file name from redis6.conf to redis.conf to align with the upgrade from redis v6 to redis v7. Also, the contents of the redis file were merged with the updated redis conf file associated with redis v7. It is worth noting that the following entries in the redis conf file are new with redis v7 (see below). The defaults were taken for these new entries.

# By default, Redis modifies the process title (as seen in 'top' and 'ps') to
# provide some runtime information. It is possible to disable this and leave
# the process name as executed by setting the following to no.
set-proc-title yes

# When changing the process title, Redis uses the following template to construct
# the modified title.
#
# Template variables are specified in curly brackets. The following variables are
# supported:
#
# {title}           Name of process as executed if parent, or type of child process.
# {listen-addr}     Bind address or '*' followed by TCP or TLS port listening on, or
#                   Unix socket if only that's available.
# {server-mode}     Special mode, i.e. "[sentinel]" or "[cluster]".
# {port}            TCP port listening on, or 0.
# {tls-port}        TLS port listening on, or 0.
# {unixsocket}      Unix domain socket listening on, or "".
# {config-file}     Name of configuration file used.
#
proc-title-template "{title} {listen-addr} {server-mode}"



# When diskless replication is enabled with a delay, it is possible to let
# the replication start before the maximum delay is reached if the maximum
# number of replicas expected have connected. Default of 0 means that the
# maximum is not defined and Redis will wait the full delay.
repl-diskless-sync-max-replicas 0


# FLUSHDB, FLUSHALL, SCRIPT FLUSH and FUNCTION FLUSH support both asynchronous and synchronous
# deletion, which can be controlled by passing the [SYNC|ASYNC] flags into the
# commands. When neither flag is passed, this directive will be used to determine
# if the data should be deleted asynchronously.

lazyfree-lazy-user-flush no


# For convenience, Redis stores all persistent append-only files in a dedicated
# directory. The name of the directory is determined by the appenddirname
# configuration parameter.

appenddirname "appendonlydir"


# Redis supports recording timestamp annotations in the AOF to support restoring
# the data from a specific point-in-time. However, using this capability changes
# the AOF format in a way that may not be compatible with existing AOF parsers.
aof-timestamp-enabled no

@mellis13 mellis13 marked this pull request as draft June 1, 2023 06:59
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #293 (0848a5e) into develop (5817084) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #293   +/-   ##
========================================
  Coverage    87.78%   87.78%           
========================================
  Files           58       58           
  Lines         3323     3323           
========================================
  Hits          2917     2917           
  Misses         406      406           
Impacted Files Coverage Δ
smartsim/database/orchestrator.py 83.21% <ø> (ø)
smartsim/_core/config/config.py 98.38% <100.00%> (ø)

@mellis13 mellis13 marked this pull request as ready for review June 1, 2023 17:59
@mellis13 mellis13 requested a review from billschereriii June 1, 2023 20:47
Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good. A few comments on Redis features that we may want to follow up on in subsequent tickets -- please open for any that you agree merit investigation
Thanks for taking care of this one!

@mellis13 mellis13 merged commit 5fd3598 into CrayLabs:develop Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants