-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redis conf file #293
Conversation
redis.conf to conform to redis naming convention.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
========================================
Coverage 87.78% 87.78%
========================================
Files 58 58
Lines 3323 3323
========================================
Hits 2917 2917
Misses 406 406
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks very good. A few comments on Redis features that we may want to follow up on in subsequent tickets -- please open for any that you agree merit investigation
Thanks for taking care of this one!
This PR changes the redis conf file name from
redis6.conf
toredis.conf
to align with the upgrade from redis v6 to redis v7. Also, the contents of the redis file were merged with the updated redis conf file associated with redis v7. It is worth noting that the following entries in the redis conf file are new with redis v7 (see below). The defaults were taken for these new entries.