-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the MacOSX runner image version #285
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
+ Coverage 87.52% 87.58% +0.05%
===========================================
Files 60 60
Lines 3374 3374
===========================================
+ Hits 2953 2955 +2
+ Misses 421 419 -2 |
doc/changelog.rst
Outdated
- Orchestrator and Colocated DB now accept a list of interfaces to bind to. The argument name is still `interface` | ||
for backward compatibility reasons. (PR281_) | ||
|
||
.. _PR285: https://github.com/CrayLabs/SmartSim/pull/285 | ||
.. _PR281: https://github.com/CrayLabs/SmartSim/pull/282 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not part of your PR, but _PR281
points to .../282
. Could you fix it (aka could you correct my mistake)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this refers to the line below the one you added)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We had pinned the MacOS X runner image to 10.15. This particular image on Github Actions began deprecation in May 2022. The runner itself is now no longer available and so all MacOS X Github actions are timing. This bumps the version to the latest image macos-12