-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix #203
Doc fix #203
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
- Coverage 84.33% 84.17% -0.16%
===========================================
Files 58 59 +1
Lines 3223 3312 +89
===========================================
+ Hits 2718 2788 +70
- Misses 505 524 +19
|
Some really good updates here, thank you! A few of the updates need to be adjusteed or reverted though -- see inline above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions. The main thing is to make sure that the line lengths do not exceed 88 characters. While we can rely on black
to fix it for us, in between those times, it makes the code nicer to look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for pushing through and getting these documentation clarifications in place!
Edits made to SmartSim documentation to improve writing quality (#203 ) Replacing passive tense with present in SmartSim documentation. Also editing grammar and punctuation errors. [ committed by @amandarichardsonn ] |
Creating PR for changes.