Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial Update #129

Merged
merged 23 commits into from
Jan 28, 2022
Merged

Tutorial Update #129

merged 23 commits into from
Jan 28, 2022

Conversation

MattToast
Copy link
Member

Updates tutorials 01, 03, and 05. Changes include:

  • Use and explain Experiment.create_run_settings and Experiment(launcher="auto")
  • Add clarifications to sections that I felt could use it
  • Minor typos/spelling/grammar

@MattToast MattToast requested a review from Spartee January 20, 2022 15:42
@MattToast
Bring up to date with develop
e4083ef 
Merge remote-tracking branch 'upstream/develop' into tutorial-update
@MattToast
Update with anonymous references
20f938d
@MattToast MattToast added the area: docs Issues related to documentation label Jan 24, 2022
@MattToast
Copy link
Member Author

Without looking to introduce documentation conflicts with the outstanding changes in #115, I have added some very minor updates for tutorial 04 as well.

Spartee
Spartee approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to fix, but otherwise LGTM.

@MattToast MattToast requested a review from al-rigazzi January 26, 2022 22:24
al-rigazzi
al-rigazzi reviewed Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos, and one thing which looks a bit confusing. Otherwise LGTM

@MattToast MattToast merged commit 53007e4 into CrayLabs:develop Jan 28, 2022
@MattToast MattToast deleted the tutorial-update branch January 28, 2022 18:20
@MattToast MattToast restored the tutorial-update branch January 28, 2022 18:42
@MattToast MattToast deleted the tutorial-update branch January 29, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-rigazzi al-rigazzi al-rigazzi left review comments

@Spartee Spartee Spartee approved these changes

Assignees
No one assigned
Labels
area: docs Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattToast @Spartee @al-rigazzi