Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base run settings to tests for LSF #108

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add base run settings to tests for LSF #108

merged 2 commits into from
Nov 4, 2021

Conversation

al-rigazzi
Copy link
Collaborator

This PR actually just adds the tests for LSF base settings, as they were already supported in the LSF launcher. Therefore, the status is now:

  • in the LSF launcher, RunSettings objects are supported
  • in conftest.py, get_base_run_settings can generate RunSettings for LSF.

Let me know if there was something else to be added!

@al-rigazzi al-rigazzi requested a review from EricGustin November 1, 2021 15:49
@al-rigazzi al-rigazzi self-assigned this Nov 1, 2021
@al-rigazzi al-rigazzi added area: lsf area: settings Issues related to Batch or Run settings area: test Issues related to the test suite labels Nov 1, 2021
EricGustin
EricGustin approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@EricGustin EricGustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that create_step for lsflauncher was previously moved up to the base launcher, these tests look good to me.

@al-rigazzi al-rigazzi merged commit 50f44c8 into CrayLabs:develop Nov 4, 2021
@al-rigazzi al-rigazzi deleted the lsf_base_settings branch November 4, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricGustin EricGustin EricGustin approved these changes

Assignees

@al-rigazzi al-rigazzi

Labels
area: settings Issues related to Batch or Run settings area: test Issues related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al-rigazzi @EricGustin