Fix Slurm handling of comma-separated env vars #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal-modification PR. Whenever an env var is found to contain a comma, we set it locally to the
srun
process and add the name of then env var (not the value!) to the list of exported env vars. Its value is then correctly passed bysrun
to the launched application. This does not change anything in how other env variables are exported/formed/formatted and the result is still human-readable.Basically, instead of trying to run the unsuccessful command:
we run