Env: dict -> Mapping

CrayLabs · Jun 26, 2024 · cabc2a0 · cabc2a0
1 parent 5572024
commit cabc2a0
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/smartsim/settings/builders/launch/alps.py b/smartsim/settings/builders/launch/alps.py
@@ -220,7 +220,7 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "aprun",

diff --git a/smartsim/settings/builders/launch/dragon.py b/smartsim/settings/builders/launch/dragon.py
@@ -69,7 +69,7 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> DragonRunRequest:
         exe_, *args = exe.as_program_arguments()
         return DragonRunRequest(

diff --git a/smartsim/settings/builders/launch/local.py b/smartsim/settings/builders/launch/local.py
@@ -79,6 +79,6 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return exe.as_program_arguments()
diff --git a/smartsim/settings/builders/launch/lsf.py b/smartsim/settings/builders/launch/lsf.py
@@ -122,7 +122,7 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "jsrun",

diff --git a/smartsim/settings/builders/launch/mpi.py b/smartsim/settings/builders/launch/mpi.py
@@ -225,7 +225,7 @@ def launcher_str(self) -> str:
         return LauncherType.Mpirun.value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return ("mpirun", *self.format_launch_args(), "--", *exe.as_program_arguments())
 
@@ -237,7 +237,7 @@ def launcher_str(self) -> str:
         return LauncherType.Mpiexec.value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "mpiexec",
@@ -254,7 +254,7 @@ def launcher_str(self) -> str:
         return LauncherType.Orterun.value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "orterun",

diff --git a/smartsim/settings/builders/launch/pals.py b/smartsim/settings/builders/launch/pals.py
@@ -156,7 +156,7 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "mpiexec",

diff --git a/smartsim/settings/builders/launch/slurm.py b/smartsim/settings/builders/launch/slurm.py
@@ -322,7 +322,7 @@ def set(self, key: str, value: str | None) -> None:
         self._launch_args[key] = value
 
     def finalize(
-        self, exe: ExecutableLike, env: dict[str, str | None]
+        self, exe: ExecutableLike, env: t.Mapping[str, str | None]
     ) -> t.Sequence[str]:
         return (
             "srun",

diff --git a/smartsim/settings/builders/launchArgBuilder.py b/smartsim/settings/builders/launchArgBuilder.py
@@ -59,7 +59,7 @@ def set(self, arg: str, val: str | None) -> None:
         """Set the launch arguments"""
 
     @abstractmethod
-    def finalize(self, exe: ExecutableLike, env: dict[str, str | None]) -> _T:
+    def finalize(self, exe: ExecutableLike, env: t.Mapping[str, str | None]) -> _T:
         """Prepare an entity for launch using the built options"""
 
     def format_launch_args(self) -> t.Union[t.List[str], None]: