Respond to review feedback

CrayLabs · Oct 16, 2023 · c6930c0 · c6930c0
1 parent 0e25a4a
commit c6930c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/conftest.py b/conftest.py
@@ -50,7 +50,6 @@
 import sys
 import typing as t
 import warnings
-import contextlib
 
 
 # pylint: disable=redefined-outer-name,invalid-name,global-statement
@@ -683,13 +682,12 @@ def setup_test_colo(
         colo_model_name: t.Optional[str] = "colocated_model",
         port: t.Optional[int] = test_port,
         on_wlm: t.Optional[bool] = False,
-        sr_test_script = fileutils.get_test_conf_path(application_file)
     ) -> Model:
         """Setup database needed for the colo pinning tests"""
 
         # get test setup
-        test_dir = fileutils.make_test_dir(level=level)
-        sr_test_script = fileutils.get_test_conf_path("send_data_local_smartredis.py")
+        test_dir = fileutils.make_test_dir(level=2)
+        sr_test_script = fileutils.get_test_conf_path(application_file)
 
         # Create an app with a colo_db which uses 1 db_cpu
         if colo_settings is None:

diff --git a/tests/on_wlm/test_colocated_model.py b/tests/on_wlm/test_colocated_model.py
@@ -48,7 +48,7 @@
 def test_launch_colocated_model_defaults(fileutils, coloutils, db_type):
     """Test the launch of a model with a colocated database and local launcher"""
 
-    db_args = { "debug":DEBUG_DB }
+    db_args = { "debug": DEBUG_DB }
 
     exp = Experiment(f"colocated_model_defaults_{db_type}", launcher=launcher)
     colo_model = coloutils.setup_test_colo(
@@ -77,7 +77,7 @@ def test_colocated_model_disable_pinning(fileutils, coloutils, db_type):
     db_args = {
         "db_cpus": 1,
         "custom_pinning": [],
-        "debug":DEBUG_DB,
+        "debug": DEBUG_DB,
     }
 
     # Check to make sure that the CPU mask was correctly generated
@@ -101,7 +101,7 @@ def test_colocated_model_pinning_auto_2cpu(fileutils, coloutils, db_type):
 
     db_args = {
         "db_cpus": 2,
-        "debug":DEBUG_DB
+        "debug": DEBUG_DB
     }
 
     # Check to make sure that the CPU mask was correctly generated
@@ -128,7 +128,7 @@ def test_colocated_model_pinning_range(fileutils, coloutils, db_type):
     db_args = {
         "db_cpus": 4,
         "custom_pinning": range(4),
-        "debug":DEBUG_DB
+        "debug": DEBUG_DB
     }
 
     colo_model = coloutils.setup_test_colo(