Bug fix (#715)

Fixed bug in _validate. [ committed by @AlyssaCote ] [ reviewed by @ankona ]
CrayLabs · Sep 20, 2024 · 5ec287c · 5ec287c
1 parent d43f7c7
commit 5ec287c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/doc/changelog.md b/doc/changelog.md
@@ -13,6 +13,7 @@ Jump to:
 
 Description
 
+- Quick bug fix in _validate
 - Add helper methods to MLI classes
 - Update error handling for consistency
 - Parameterize installation of dragon package with `smart build`

diff --git a/smartsim/_core/mli/infrastructure/control/request_dispatcher.py b/smartsim/_core/mli/infrastructure/control/request_dispatcher.py
@@ -280,7 +280,7 @@ def _check_feature_stores(self, request: InferenceRequest) -> bool:
         fs_actual = {item.descriptor for item in self._feature_stores.values()}
         fs_missing = fs_desired - fs_actual
 
-        if self.has_featurestore_factory:
+        if not self.has_featurestore_factory:
             logger.error("No feature store factory configured")
             return False
 

diff --git a/tests/dragon/test_error_handling.py b/tests/dragon/test_error_handling.py
@@ -460,12 +460,6 @@ def test_dispatcher_pipeline_stage_errors_handled(
 
     mock_reply_fn = mock_pipeline_stage(monkeypatch, integrated_worker, stage)
 
-    monkeypatch.setattr(
-        request_dispatcher,
-        "_validate_request",
-        MagicMock(return_value=True),
-    )
-
     if stage not in ["fetch_inputs"]:
         monkeypatch.setattr(
             integrated_worker,