fix for incorrect logging message format/args (#330)

Fix for incorrect message format/args

[ committed by @ankona ]
[ reviewed by @mellis13 ]

doc/changelog.rst

@@ -19,12 +19,15 @@ To be released at some future point in time
 
 Description
 
+- Fix malformed logging format strings
 - Update linting support and apply to existing errors
 
 Detailed Notes
 
+- Fix incorrectly formatted positional arguments in log format strings (PR330_)
 - Update pylint dependency, update .pylintrc, mitigate non-breaking issues, suppress api breaks (PR311_)
 
+.. _PR330: https://github.com/CrayLabs/SmartSim/pull/330
 .. _PR311: https://github.com/CrayLabs/SmartSim/pull/311
 
 0.5.0

smartsim/_core/entrypoints/colocated.py

@@ -207,15 +207,10 @@ def main(
 
     try:
         logger.debug(
-            (
-                "\n\nColocated database information\n"
-                "\n\tIP Address(es): {}"
-                "\n\tCommand: {}\n\n"
-                "\n\t# of Database CPUs: {}"
-            ),
-            ' '.join(ip_addresses + [lo_address]),
-            ' '.join(cmd),
-            db_cpus
+            "\n\nColocated database information\n"
+            f"\n\tIP Address(es): {' '.join(ip_addresses + [lo_address])}"
+            f"\n\tCommand: {' '.join(cmd)}\n\n"
+            f"\n\t# of Database CPUs: {db_cpus}"
         )
     except Exception as e:
         cleanup()

smartsim/_core/launcher/step/alpsStep.py

@@ -106,8 +106,8 @@ def _set_alloc(self) -> None:
         elif "COBALT_JOBID" in os.environ:
             self.alloc = os.environ["COBALT_JOBID"]
             logger.debug(
-                "Running on Cobalt allocation {} gleaned from user environment",
-                self.alloc,
+                f"Running on Cobalt allocation {self.alloc} gleaned "
+                "from user environment"
             )
         else:
             raise AllocationError(