Respond to review feedback

CrayLabs · Oct 4, 2023 · 4086893 · 4086893
1 parent c48db14
commit 4086893
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/conftest.py b/conftest.py
@@ -50,7 +50,6 @@
 import sys
 import typing as t
 import warnings
-import contextlib
 
 
 # pylint: disable=redefined-outer-name,invalid-name,global-statement
@@ -679,12 +678,11 @@ def setup_test_colo(
         exp: Experiment,
         db_args: t.Dict[str, t.Any],
         colo_settings: t.Optional[t.Dict[str, t.Any]] = None,
-        on_wlm: t.Optional[bool] = False
+        on_wlm: bool = False
     ) -> Model:
         """Setup things needed for setting up the colo pinning tests"""
         # get test setup
-        level = 3 if on_wlm else 2
-        test_dir = fileutils.make_test_dir(level=level)
+        test_dir = fileutils.make_test_dir(level=2)
         sr_test_script = fileutils.get_test_conf_path("send_data_local_smartredis.py")
 
         # Create an app with a colo_db which uses 1 db_cpu

diff --git a/tests/on_wlm/test_colocated_model.py b/tests/on_wlm/test_colocated_model.py
@@ -48,7 +48,7 @@
 def test_launch_colocated_model_defaults(fileutils, coloutils, db_type):
     """Test the launch of a model with a colocated database and local launcher"""
 
-    db_args = { "debug":DEBUG_DB }
+    db_args = { "debug": DEBUG_DB }
 
     exp = Experiment(f"colocated_model_defaults_{db_type}", launcher=launcher)
     colo_model = coloutils.setup_test_colo(
@@ -76,7 +76,7 @@ def test_colocated_model_disable_pinning(fileutils, coloutils, db_type):
     db_args = {
         "db_cpus": 1,
         "custom_pinning": [],
-        "debug":DEBUG_DB,
+        "debug": DEBUG_DB,
     }
 
     # Check to make sure that the CPU mask was correctly generated
@@ -99,7 +99,7 @@ def test_colocated_model_pinning_auto_2cpu(fileutils, coloutils, db_type):
 
     db_args = {
         "db_cpus": 2,
-        "debug":DEBUG_DB
+        "debug": DEBUG_DB
     }
 
     # Check to make sure that the CPU mask was correctly generated
@@ -125,7 +125,7 @@ def test_colocated_model_pinning_range(fileutils, coloutils, db_type):
     db_args = {
         "db_cpus": 4,
         "custom_pinning": range(4),
-        "debug":DEBUG_DB
+        "debug": DEBUG_DB
     }
 
     colo_model = coloutils.setup_test_colo(