Skip to content

Commit

Permalink
Added PR324 and PR325 to changelog (#333)
Browse files Browse the repository at this point in the history
Added PR324 and PR325 to changelog

 [ committed by @juliaputko ]
 [ reviewed by @ankona]
  • Loading branch information
juliaputko authored Aug 4, 2023
1 parent 8ce3c1d commit 164a832
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,23 @@ Description

- Log ignored error messages from `sacct`
- Fix malformed logging format strings
- Fix bug when user specify CPU and devices greater than 1
- Fix bug when get_allocation called with reserved keywords
- Update linting support and apply to existing errors

Detailed Notes

- Log errors reported from slurm WLM when attempts to retrieve status fail (PR331_, PR332_)
- Fix incorrectly formatted positional arguments in log format strings (PR330_)
- Add error if user calls get_allocation with reserved keywords in slurm get_allocation (PR325_)
- Add error when user requests CPU with devices greater than 1 within add_ml_model and add_script (PR324_)
- Update pylint dependency, update .pylintrc, mitigate non-breaking issues, suppress api breaks (PR311_)

.. _PR332: https://github.com/CrayLabs/SmartSim/pull/332
.. _PR331: https://github.com/CrayLabs/SmartSim/pull/331
.. _PR330: https://github.com/CrayLabs/SmartSim/pull/330
.. _PR325: https://github.com/CrayLabs/SmartSim/pull/325
.. _PR324: https://github.com/CrayLabs/SmartSim/pull/324
.. _PR311: https://github.com/CrayLabs/SmartSim/pull/311

0.5.0
Expand Down
1 change: 1 addition & 0 deletions tests/backends/test_dbmodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ def test_colocated_db_model_errors(fileutils, wlmutils, mlutils):
with pytest.raises(SSUnsupportedError):
colo_ensemble.add_model(colo_model)

@pytest.mark.skipif(not should_run_tf, reason="Test needs TensorFlow to run")
def test_inconsistent_params_db_model():
"""Test error when devices_per_node parameter>1 when devices is set to CPU in DBModel"""

Expand Down

0 comments on commit 164a832

Please sign in to comment.