Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket time out environment variable #474

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

mellis13
Copy link
Collaborator

@mellis13 mellis13 commented Apr 1, 2024

This PR adds the socket timeout parameter as a user-configurable option via environment variables. This is important because for commands such as set_model with large models, the internal socket timeout may be exceeded and multiple retries will have no positive affect because more time is needed to complete the action.

@mellis13 mellis13 added area: C++ Issues related to the C++ client type: usability Issues related to ease of use labels Apr 1, 2024
@mellis13 mellis13 requested a review from ashao April 1, 2024 21:59
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (27ac572) to head (86ef2b9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #474      +/-   ##
===========================================
+ Coverage    78.80%   78.82%   +0.01%     
===========================================
  Files           97       97              
  Lines         7356     7362       +6     
===========================================
+ Hits          5797     5803       +6     
  Misses        1559     1559              
Files Coverage Δ
include/redisserver.h 60.00% <ø> (ø)
src/cpp/redis.cpp 54.63% <100.00%> (+0.10%) ⬆️
src/cpp/rediscluster.cpp 66.30% <100.00%> (+0.04%) ⬆️
src/cpp/redisserver.cpp 98.96% <100.00%> (+0.04%) ⬆️

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm going to put a followup ticket to add the list of SmartRedis configurable parameters to the documentation. They're a bit hard to find at this point and should be surfaced.

Please merge in develop which has the fixes for CI, then this should be good to merge.

@mellis13 mellis13 merged commit 51c3dc6 into CrayLabs:develop Apr 3, 2024
38 checks passed
@amandarichardsonn amandarichardsonn added the type: feature Issues that include feature request or feature idea label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C++ Issues related to the C++ client type: feature Issues that include feature request or feature idea type: usability Issues related to ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants