Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a contributing reference to SmartRedis pointing to SmartSim #395

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ashao
Copy link
Collaborator

@ashao ashao commented Aug 23, 2023

Puts links to the contribution guidelines in the SmartSim Github repo and on the CrayLabs documentation. Note: these links will not work correctly yet.

  • The SmartSim link will work after the PR is merged
  • CrayLabs documentation will be updated on next release

@ashao ashao added the area: docs Issues related to documentation label Aug 23, 2023
@ashao ashao requested a review from MattToast August 23, 2023 20:39
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM baring a couple of small typos

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing


.. _PR402: https://github.com/CrayLabs/SmartRedis/pull/402
.. _PR396: https://github.com/CrayLabs/SmartRedis/pull/396
.. _PR394: https://github.com/CrayLabs/SmartRedis/pull/395
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _PR394: https://github.com/CrayLabs/SmartRedis/pull/395
.. _PR395: https://github.com/CrayLabs/SmartRedis/pull/395

@ashao ashao merged commit faf58b3 into CrayLabs:develop Sep 28, 2023
@ashao ashao deleted the contributing branch September 28, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants