Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended section on dataset aggregation #390

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

billschereriii
Copy link
Contributor

Expanded the documentation section on DataSet aggregation and moved it to a new Advanced Topics page

@billschereriii billschereriii added the area: docs Issues related to documentation label Aug 9, 2023
@billschereriii billschereriii requested a review from ashao August 9, 2023 19:44
@billschereriii billschereriii self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #390 (da57605) into develop (ea93e2f) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
+ Coverage    78.32%   78.35%   +0.02%     
===========================================
  Files           97       97              
  Lines         7050     7058       +8     
===========================================
+ Hits          5522     5530       +8     
  Misses        1528     1528              

see 8 files with indirect coverage changes

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments, but otherwise thank you for expanding this section!

Copy link
Collaborator

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs! Just a couple of small questions/comments.

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes you made in response to Matt's comments. Thanks again!

@billschereriii billschereriii merged commit 6413643 into CrayLabs:develop Aug 15, 2023
@billschereriii billschereriii deleted the dsag branch August 15, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants