Make testing more robust #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billschereriii
added
area: build
ashao
requested changes
Jul 13, 2023
Makefile
Outdated
| echo "Shutting down standalone Redis server" && \ | ||
| python utils/launch_redis.py --port $(SR_TEST_PORT) --nodes 1 --stop && \ | ||
| exit $$testresult) && \ |
There was a problem hiding this comment.
I think this would be slightly more bash-like:
test $$testresult -eq 0 || echo "Tests failed"; exit $$test_result
There was a problem hiding this comment.
I like that, will adopt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to shut down Redis server even if tests fail.
Do so while still reporting the result of testing