Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update URI for installation instructions #380

Merged
merged 2 commits into from
Jul 17, 2023
Merged

update URI for installation instructions #380

merged 2 commits into from
Jul 17, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 13, 2023

Update the URI for documentation on SmartRedis installation.

@ankona ankona requested a review from ashao July 13, 2023 22:09
billschereriii
billschereriii approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please don't forget to update the changelog

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #380 (7a1a1f4) into develop (de066d0) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7a1a1f4 differs from pull request most recent head 12d44ae. Consider uploading reports for the commit 12d44ae to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #380      +/-   ##
===========================================
- Coverage    78.39%   78.37%   -0.02%     
===========================================
  Files           97       97              
  Lines         7067     7067              
===========================================
- Hits          5540     5539       -1     
- Misses        1527     1528       +1

see 1 file with indirect coverage changes

@ankona ankona merged commit 39292dc into CrayLabs:develop Jul 17, 2023
@ankona ankona deleted the install-uri branch July 17, 2023 15:33
@MattToast MattToast added the area: docs Issues related to documentation label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billschereriii billschereriii billschereriii approved these changes

@ashao ashao Awaiting requested review from ashao

Assignees
No one assigned
Labels
area: docs Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankona @billschereriii @MattToast