Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10 #360

Merged
merged 8 commits into from
Jun 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_post_merge_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
os: [ubuntu-20.04] # cannot test on macOS as docker isn't supported on Mac
compiler: [intel, 8, 9, 10, 11] # intel compiler, and versions of GNU compiler
rai_v: [1.2.4, 1.2.5] # versions of RedisAI
py_v: ['3.7.x', '3.8.x', '3.9.x'] # versions of Python
py_v: ['3.7.x', '3.8.x', '3.9.x', '3.10.x'] # versions of Python
env:
FC: gfortran-${{ matrix.compiler }}
GCC_V: ${{ matrix.compiler }} # used when the compiler is gcc/gfortran
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
matrix:
os: [ubuntu-20.04] # cannot test on macOS as docker isn't supported on Mac
rai_v: [1.2.4, 1.2.5] # versions of RedisAI
py_v: ['3.7.x', '3.8.x', '3.9.x'] # versions of Python
py_v: ['3.7.x', '3.8.x', '3.9.x', '3.10.x'] # versions of Python
compiler: [intel, 8, 9, 10, 11] # intel compiler, and versions of GNU compiler
env:
FC: gfortran-${{ matrix.compiler }}
Expand Down
3 changes: 3 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To be released at some future point in time

Description

- Add support for Python 3.10
- Updated setup.py to work with the new build system
- Remove unneeded method from Python SRObject class
- Fixed a memory leak in the C layer
Expand All @@ -26,6 +27,7 @@ Description

Detailed Notes

- List Python 3.10 support and loosen PyTorch requirement to allow for versions support Python 3.10 (PR360_)
- Streamlined setup.py to simplify Python install (PR359)
- Remove from_pybind() from Python SRObject class as it's not needed and didn't work properly anyway (PR358_)
- Fixed memory leaked from the C layer when calling get_string_option() (PR357_)
Expand All @@ -50,6 +52,7 @@ users need not import `iso_c_binding` in their own applications (PR340_)
- New pip-install target in Makefile will be a dependency of the lib target going forward so that users don't have to manually pip install SmartRedis in the future (PR330_)
- Added ConfigOptions class and API, which will form the backbone of multiDB support (PR303_)

.. _PR360: https://github.com/CrayLabs/SmartRedis/pull/360
.. _PR359: https://github.com/CrayLabs/SmartRedis/pull/359
.. _PR358: https://github.com/CrayLabs/SmartRedis/pull/358
.. _PR357: https://github.com/CrayLabs/SmartRedis/pull/357
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ requires = ["setuptools>=42",
build-backend = "setuptools.build_meta"

[tool.black]
target-version = ['py37', 'py38', 'py39']
target-version = ['py37', 'py38', 'py39', 'py310']
exclude = '''
(
| \.egg
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ black==23.3.0
isort==5.6.4
pylint==2.6.0
breathe==4.26.0
torch==1.7.1
torch>=1.7.1
sphinx-fortran==1.1.1
jinja2==3.0.3
3 changes: 2 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ classifiers =
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
License :: OSI Approved :: BSD License
Intended Audience :: Science/Research
Topic :: Scientific/Engineering
Expand All @@ -43,7 +44,7 @@ dev =
black==20.8b1
isort==5.6.4
pylint==2.6.0
torch==1.7.1
torch>=1.7.1

doc=
sphinx==3.1.1
Expand Down