SmartRedis test system refactor

[billschereriii]

Massive overhaul of test system, automating launch and teardown of Redis and removing the need for the setup_test_env.sh script

[codecov]

Codecov Report

Merging #356 (efa0b68) into develop (11248bb) will increase coverage by 78.36%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #356       +/-   ##
============================================
+ Coverage         0   78.36%   +78.36%     
============================================
  Files            0       97       +97     
  Lines            0     7057     +7057     
============================================
+ Hits             0     5530     +5530     
- Misses           0     1527     +1527     

see 97 files with indirect coverage changes

[MattToast]

Looks amazing!

I went on a deep dive into the launch_redis.py file basically just trying to remove the need for shell=True in the Popen calls and calling out some style things along the way.

I skimmed through the Makefile as well and that, to the best of my ability looks great with one outstanding questiong.

Overall, only some pedantic feedback! LGTM!!

[ashao]

Looks good to me, with the exception of the one change to the detection of redis-cli. This should avoid the need to set another environment variable.

Thanks for this; it's a HUGE improvement

[ashao]

I think the easier way to do this is to use shutil.which('redis-cli') and then set the rediscli variable at the top of the file and/or make it into a small function

[billschereriii]

We actually have fairly substantial changes based on whether we're in CI/CD or not, so this isn't the only thing affected. Can discuss more offline

[MattToast]

LGTM!! Ship it!!