Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline dataset operations #311

Merged
merged 8 commits into from
Mar 13, 2023
Merged

Conversation

billschereriii
Copy link
Contributor

Add pipelining support for put, get, and copy dataset operations

@billschereriii billschereriii added type: feature Issues that include feature request or feature idea type: performance Issues related to performance area: C++ Issues related to the C++ client labels Mar 9, 2023
@billschereriii billschereriii self-assigned this Mar 9, 2023
@billschereriii billschereriii requested a review from mellis13 March 9, 2023 18:43
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #311 (5d4558c) into develop (188c12b) will decrease coverage by 0.16%.
The diff coverage is 70.73%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    65.24%   65.08%   -0.16%     
===========================================
  Files          100      100              
  Lines         7538     7601      +63     
===========================================
+ Hits          4918     4947      +29     
- Misses        2620     2654      +34     
Impacted Files Coverage Δ
include/redisserver.h 0.00% <ø> (ø)
src/cpp/redis.cpp 48.33% <46.66%> (-2.02%) ⬇️
include/client.h 50.00% <100.00%> (ø)
src/cpp/client.cpp 87.34% <100.00%> (+0.05%) ⬆️
src/cpp/rediscluster.cpp 64.63% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@billschereriii billschereriii merged commit 68a7a84 into CrayLabs:develop Mar 13, 2023
@billschereriii billschereriii deleted the pds branch March 13, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C++ Issues related to the C++ client type: feature Issues that include feature request or feature idea type: performance Issues related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants