Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C interface for dataset aggregation #257

Merged
merged 11 commits into from
Jun 3, 2022

Conversation

billschereriii
Copy link
Contributor

Implement a C interface for dataset aggregation

@billschereriii billschereriii added the area: C Issues related to the C client label May 23, 2022
@billschereriii billschereriii requested a review from ashao May 23, 2022 23:46
@billschereriii billschereriii self-assigned this May 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #257 (eeceac7) into develop (fea2289) will increase coverage by 0.22%.
The diff coverage is 93.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage    79.96%   80.19%   +0.22%     
===========================================
  Files           55       55              
  Lines         3384     3443      +59     
===========================================
+ Hits          2706     2761      +55     
- Misses         678      682       +4     
Impacted Files Coverage Δ
src/python/module/smartredis/client.py 95.11% <93.22%> (-0.32%) ⬇️

@billschereriii billschereriii marked this pull request as ready for review June 3, 2022 16:44
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, the only substantive thing would be to slightly refactor the python test to allow it to be more scaleable.

@billschereriii billschereriii merged commit 04e95c6 into CrayLabs:develop Jun 3, 2022
@billschereriii billschereriii deleted the c-agg branch June 3, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C Issues related to the C client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants