Set enum_kind based on Fortran standard #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #231 +/- ##
========================================
Coverage 82.46% 82.46%
========================================
Files 51 51
Lines 2840 2840
========================================
Hits 2342 2342
Misses 498 498 |
The enum_kind is now set in the fortran_c_interop module but made publicly availabe via the client and dataset modules. This differs from the previous implementation which attempted to set enum_kind by creating a dummy enum and detecting the kind of it at compile time. This however, broke compilation with GCC 6.3.0, because that compiler chain allows for different 'types' of enums (a departure from the Fortran standard). This also removes the explicit declaration of the kind in most of the tests since Fortran assignment should automatically convert the value to the correct kind that the variable (e.g. err_code) is declared as.
ashao
force-pushed
the
explicit_kind_enum
branch
from
d225efa to
dfac492
Compare
billschereriii
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enum_kind is now set in the fortran_c_interop module but made
publicly availabe via the client and dataset modules. This differs
from the previous implementation which attempted to set enum_kind
by creating a dummy enum and detecting the kind of it at compile
time. This however, broke compilation with GCC 6.3.0, because
that compiler chain allows for different 'types' of enums (a
departure from the Fortran standard).
This also removes the explicit declaration of the kind in most of
the tests since Fortran assignment should automatically convert
the value to the correct kind that the variable (e.g. err_code)
is declared as.
Closes #216